[dev] [PATCH] wrong dsn assembly in lib/Auth/imap.php

[Michael M Slusarz]

Quoting Roman Neuhauser <neuhauser at bellavista.cz>:

| btw, why doesn't IMP use horde/lib/Auth/imap.php?

Because all Auth_imap:: (and all Auth_*::authenticate()) does is determine
if the username/password is valid for the particular backend - it is
strictly an *authentication* interaction.  In IMP, not only do we want to
determine if authentication is valid, but we need to keep the resulting
stream open so we can use to actually interact with the IMAP system. 
Additionally, all sort of session/global variables are used/set in the
authentication process (in HEAD, see
imp/lib/Auth/imp.php::_authenticate()). This extended interaction with the
actual IMAP backend is not what the Auth:: class was meant to provide.

I have done a little bit lately with trying to tie the Auth:: stuff with IMP
authentication, but I'm sure more can be done.  Then again, the gains by
rewriting the code to use Auth_imap:: in IMP appear to be fairly minimal at
best.

michael

______________________________________________
Michael Slusarz [slusarz at bigworm.colorado.edu]
The University of Colorado at Boulder