[dev] [PATCH] IMP : rework of the Quota class

Etienne Goyer etienne.goyer at linuxquebec.com
Wed Sep 24 05:26:03 PDT 2003


On Wed, Sep 24, 2003 at 01:03:35AM +0200, Jan Schneider wrote:
> A few comments as far as I can tell from reading the diff only:
> - Are you missing a patch against quota.inc?

Oups.

> - The getQuota() methods should return a PEAR_Error, not a string if an
> error occured.

I'll fix that.

> - Please keep the quota code in folders.php at the same place and with the
> same special code (opposed to mailbox.php and message.php) as before. It's
> there for a reason.

I'll fix that too.  What is the reason for doing it this way, if it's
not too obscure ?

Hopefully, I'll post a new patch with requested correction later on this 
morning.

Regards,


-- 
Etienne Goyer                    Linux Québec Technologies Inc.
http://www.LinuxQuebec.com       etienne.goyer at linuxquebec.com


More information about the dev mailing list