[dev] Re: [cvs] commit: horde/lib Perms.php

[Marko Djukic]

Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Marko Djukic <tech at oblo.com>:
>
> >   Log:
> >   add functions to simplify the code in the scripts
>
> renderPermissionsTree() does not belong in the main Perms class; I certainly
> appreciate the simplifying of permissions scripts, though. How about moving
> it
> into Perms/UI.php in a new Perms_UI class?

yes, that sounds like a good idea. i was not entirely happy with the code as it
is now but does look better than lots of code repetition earlier. plus the
other goal was to get it to be more versatile where it can be "imported" into
an app so that there could be freedom to do more app-specific perms stuff
within the app.

> And you should probably add an
> optional dependancy on the Horde_Tree package to the Perms package to cover
> that.

k, sure.

> The other functions look okay, but I'd like to see some of the variable names
> and the array structure passed in be more verbose.

sure. not happy with some of the variables, too confusing.

> Would you object to my
> tweaking the code a bit, and then helping fix up the calling scripts?

no probs.

i'm a bit K.O. with my connections these days. not sure how long it will last.
so go ahead and tweak as much as you want, i'll leave it for now and do stuff i
can do locally and catch up when i get back online in a meaningful way.

the only other bit i didn't get a chance to commit before i lost the connection
was the app's advertising their available perms through the api... but that can
wait.

plus the horde_form i started to change a bit to allow the sections to be
presented either as vertical drop down sections (as they are now) or as
horizontal tabs at the top. but again, can wait.

m.