[dev] Patch for Category::getShortName

jvandal at infoteck.qc.ca jvandal at infoteck.qc.ca
Sat Oct 25 08:05:24 PDT 2003


> > If I refer to the comment of Category::getShortName, this function is for 
> > display purpose only so if I change this function to get a "human text", I 
> > will not "break" any application, exact ? :) 
> 
> Probably not, but you're loading a perms object and checking for a permission 
> on 
> every getshortname call? Aside from the innefficiency of this, categories are 
> used for things other than permissions far more often than not, and this will 
> actually give a ton of false data if a non-permission category has the same 
> name as a permission. 

Ok ;) so, if I create a fuction like Perms::getTitle and change call from Category::getShortName to Perms::getTitle on perms page ? This will solve the inefficiency and false data ?

--
Joel Vandal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 1030 bytes
Desc: Clef publique PGP
Url : http://lists.horde.org/archives/dev/attachments/20031025/ddb2eed8/attachment.bin


More information about the dev mailing list