[dev] Horde Metar Block

[Marcus I. Ryan]

Sorry I was slow on this.  The buildMetarDB.php script failed so miserably on
PgSQL that I gave up until RC2 came out (chuck had said you submitted some
patches to him).  It's still broken, so I patched mine and sent my patches in
as well.  Now I have the database and I'm ready to go, but it's RC2, so I
should probably bug you for your new patch anyway.  That said, comments on
the previous:

I just skimmed, but it looks good except:
* You shouldn't have to build a DSN to the DB connect call; just pass it
$conf['sql'].
* The html might get nudged a little (I'm not sure about multiple <br /> tags
to get multiple line breaks) but other than that, looks good.

--
Marcus I. Ryan, marcus at horde.org
-----------------------------------------------------------------------
 "Love is a snowmobile racing across the tundra and then suddenly it
 flips over, pinning you underneath.  At night, the ice weasels come."
                 -- Matt Groening
-----------------------------------------------------------------------


Quoting Rick Emery <rick at emery.homelinux.net>:

> Just FYI,
>
> Services_Weather RC2 was posted to the pear site yesterday. In addition to
> bug
> fixes, there were some changes made to the parsing code. I have modified
> the
> metar.php block to properly use the libraries (the original file I posted
> works
> with RC1, but will not display properly with RC2). Additionally, I've made
> some
> cosmetic changes (display the location description instead of the code,
> display
> labels in bold).
>
> Rather than populate the list with a new file every time I make a change,
> I'll
> wait until I either get feedback on the original I posted (regarding coding
> standards, use of "isset", etc) or until the new version is requested. That
> will
> allow me to further test and make changes until somebody's ready to commit
> it.
>
> Thanks,
> Rick
>
>
> --
> Horde developers mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org
>
>


----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.