[dev] Horde Metar Block

Rick Emery rick at emery.homelinux.net
Fri Dec 5 13:07:08 PST 2003


Quoting "Marcus I. Ryan" <marcus at horde.org>:

> I just skimmed, but it looks good except:
> * You shouldn't have to build a DSN to the DB connect call; just pass it
> $conf['sql'].

This is beautiful! Exactly the kind of feedback I was hoping for! I've made this
change in the version attached.

> * The html might get nudged a little (I'm not sure about multiple <br /> tags
> to get multiple line breaks) but other than that, looks good.

I've modified the code a little, to use a <p /> tag instead of <br /> tags.

Feel free to make any changes you feel are fitting. I don't claim to be anything
but a beginning php coder.

Thanks,
Rick

--
Rick Emery

"When once you have tasted flight, you will forever walk the Earth
 with your eyes turned skyward, for there you have been, and there
 you will always long to return"
                                              -- Leonardo Da Vinci
-------------- next part --------------
Index: registry.php.dist
===================================================================
RCS file: /repository/horde/config/registry.php.dist,v
retrieving revision 1.193
diff -u -r1.193 registry.php.dist
--- registry.php.dist	19 Nov 2003 10:55:12 -0000	1.193
+++ registry.php.dist	5 Dec 2003 20:55:41 -0000
@@ -612,3 +612,7 @@
 $this->applets['moon'] = array(
     'name' => _("Moon Phases"),
 );
+
+$this->applets['metar'] = array(
+    'name' => _("Metar Weather"),
+);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: metar.php
Type: application/x-httpd-php
Size: 12541 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20031205/52357983/metar.bin


More information about the dev mailing list