[dev] Groups and History?

[Carlos Pedrinaci]

Sorry.. I replied again to your mail box instead of the list :(

El sáb, 10-01-2004 a las 19:03, Chuck Hagenbuch escribió:
> Quoting Carlos Pedrinaci <cpedrinaci at yahoo.es>:
> 
> > Here is a patch for that feature.
> > For db space reasons, whenever a group is deleted or a user is removed
> > from a group the History for that item is also removed.
> > I think this could be added as an option as Jason said and allow the
> > admin to decide whether to use that log and whether to keep track of
> > deleted items also or not.
> 
> I've committed a modified version of this patch, that doesn't actually delete
> histories when things are deleted, since that defeats some of the purpose of
> the audit log in the first place.
Indeed. Just wanted to reduce space usage.

 I also stored the adduser/deleteuser actions
> in the same history as the group, for simplicity. Let me know what you think.
> And thanks!
That looks ok.
There is however a little thing I'd like to modify: when adding/removing
a user I'd like to store also the user that was actually added or
removed.

Find enclosed a mini-patch for that. The patch does also delete the
$userId param on getGUID as it is not needed anymore.

Carlos

> 
> -chuck
> 
> --
> Charles Hagenbuch, <chuck at horde.org>
> "I'm really... I'm not too fascinated by green food." - Average Joe
> 
> -- 
> Horde developers mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.txt
Type: text/x-patch
Size: 882 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20040110/bb70acb5/patch.bin