[dev] "Re:" string fix

Vilius Sumskas vilius at lnk.lt
Thu May 13 04:32:04 PDT 2004


Cituojama Jan Schneider <jan at horde.org>:

> Zitat von Vilius Sumskas <vilius at lnk.lt>:
>
>> this fixes "re:" string with non english translations.
>
> I don't think that makes sense. We force the usage of "Re:" for "new"
> replies, for a good reason. Thus we should also add a "Re:" on second
> replies if the original reply didn't contain it.
>
> Jan.

Then you should remove second translated "Re: " in that file. See attachment.
Because now on non-english installations this IF is always true and translated
Re: is added everytime i post reply.

--
    Vilius

-------------- next part --------------
Index: edit.php
===================================================================
RCS file: /repository/agora/messages/edit.php,v
retrieving revision 1.45
diff -u -r1.45 edit.php
--- edit.php	26 Apr 2004 12:43:19 -0000	1.45
+++ edit.php	13 May 2004 11:30:09 -0000
@@ -108,7 +108,7 @@
 
         /* Set up the form subject with the parent subject. */
         if (String::lower(String::substr($message_array['plain_subject'], 0, 3)) != 're:') {
-            $message_array['plain_subject'] = sprintf(_("Re: %s"), $message_array['plain_subject']);
+            $message_array['plain_subject'] = sprintf('Re: %s', $message_array['plain_subject']);
         }
         $vars->set('message_subject', $message_array['plain_subject']);
         require_once 'Horde/Text.php';


More information about the dev mailing list