[dev] [patch] Sidebar logo padding

[Stuart Bingë]

Hello all,

Would you guys have any objections to me commiting this patch?

What it does is remove the table-within-a-table that the logo was residing in 
(why was it necessary to have this in the first place?), adds an extra column 
next to the logo (with id "logopad"), and changes "themelogo" to an id 
instead of a class.

I've also added logic to only set id="themelogo" if $conf['logo']['image'] is 
not set, meaning if you specify a logo in the config file it overrides any 
theme-specified logo.

The main reason that I want this is for themes that use the "sidebar-panel" 
class to create a themed sidebar panel, specifically with border-right set. 
With this new patch you are able to set both $css['.sidebar .menu']
['border-right'] and $css['.sidebar-panel']['border-right'], and have a 
border going from the top of the screen downwards, along the right-hand side 
of the sidebar panel, and have it actually line up.

Previously when you try to set the above two border styles the logo cell's 
border would be slightly to the right of the sidebar panel's border, as the 
logo spanned both the sidebar panel and the extra padding column that is 
present.

The only disadvantage to this is logos now have to be a bit narrower than 
140px. As far as I can tell it also does not break any of the existing 
themes.

Regards,

-- 
Stuart Bingë
Code Fusion cc.

Office: +27 11 673 0411
Mobile: +27 83 298 9727
Email: s.binge at codefusion.co.za

Tailored email solutions; Kolab specialists.
http://www.codefusion.co.za/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sidebar-padding.diff
Type: text/x-diff
Size: 1008 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20040618/6ac44430/sidebar-padding.bin