[dev] [PATCH] Wholesome Linkage

[Andrew Coleman]

Quoting Chuck Hagenbuch <chuck at horde.org>:
> To note for the future:
> * please read horde/docs/CODING_STANDARDS, and look at the 
> differences between
> what you submitted and what I committed.
This new stuff should be much more to the standards.

> To do before the bounty can be paid:
> * linked attachments need to work when uploaded attachments aren't already
> stored in the VFS.
Tested on my development installation with and without the VFS, both appear to
work.

> * need a way for administrators to turn linked attachments on/off. 
> Ideal would
> be a preference which says "always send links, never send links, or let me
> choose". This would then only show the compose screen option if the 
> user wants
> to choose, and has the benefit of letting the administrator lock in any
> option.
I used two preferences for this one. One to enable linked attachments and the
other to force all attachments as links. This seemed a bit easier because
having three values would mean that at some point a string comparison would
have to be made... Seems a bit slower than a boolean comparison. Plus, when/if
it gets translated, no other weirdnesses should be encountered.

> * looks like you missed sending the patch to imp/config/prefs.php.dist
Oops :P

--
Andrew Coleman
mercury at appisolutions.net
/-\   The ASCII
\ /   Ribbon Campaign
  X    Against HTML
/ \   E-Mail!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: imp-link.patch
Type: text/x-patch
Size: 8383 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20040706/9b5ff051/imp-link.bin