[dev] [PATCH] Wholesome Linkage

[Chuck Hagenbuch]

Quoting Andrew Coleman <mercury at appisolutions.net>:

> This new stuff should be much more to the standards.

Yes. One minor note: gettext (specifically xgettext) doesn't pick up 
_(' as the
start of a string to be translated - you need to use _(" (double quote).

> Tested on my development installation with and without the VFS, both 
> appear to work.

Looks good now - patch is committed.

> I used two preferences for this one. One to enable linked attachments and the
> other to force all attachments as links. This seemed a bit easier because
> having three values would mean that at some point a string comparison would
> have to be made... Seems a bit slower than a boolean comparison.

No real worry with speed in terms of a string vs. boolean for that. And 
for the
future, it'd be nice to have these as user preferences, not config 
options. But
this definitely satisfies the requirement, thanks!

-chuck

--
"Regard my poor demoralized mule!" - Juan Valdez