[dev] Fwd: [patch] Ansel doesn't honour online help setting

Roel Gloudemans roel at gloudemans.info
Wed Aug 18 12:34:46 PDT 2004


Oops the menu_helponly.patch misses a {

Sorry,Roel

---- Forwarded message from roel at gloudemans.info -----
    Date: Wed, 18 Aug 2004 21:29:05 +0200
    From: Roel Gloudemans <roel at gloudemans.info>
Reply-To: Roel Gloudemans <roel at gloudemans.info>
 Subject: [patch] Ansel doesn't honour online help setting
      To: dev at lists.horde.org

Hi all,

I noticed that Ansel doesn't honour the

$conf['user']['online_help']

setting from the global Horde config. I made a patch for this for
templates/menu/menu.inc

I also added one other thing I want to drop. Normally, most Horde apps (except
e.g. giapeto) show the Option icon in the top menubar when accessing it as
guest. In my opninion this is mostly not wanted. There are a few possibilities

1) Show it anyway but disable it for specific apps (like giapeto)
2) Never show the icon (like in the included patch)
3) Make a configuration variable for it like for the online help (this produces
the most consistent result)
4) Make it configurabe for each application

What's the best option? (I'm willing to implement it if it's option 2 or 3)

I created two versions of the patch, one with and one without the disabling of
the options icon.

Cheers,
Roel.

----- End forwarded message -----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: menu_helponly.inc.patch
Type: text/x-patch
Size: 521 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20040818/92e9b719/menu_helponly.inc.bin


More information about the dev mailing list