[dev] help/options links

Chuck Hagenbuch chuck at horde.org
Thu Aug 26 13:49:33 PDT 2004


Quoting Roel Gloudemans <roel at gloudemans.info>:

>>> Showlink is set up in a generic way independent on link type. (Any
>>> $conf['link']['...'] works. Each link however is set up in a different way.
>>> Some logic would then have te be added to showLink (showlink then becomes a
>>> 'gateway' for Help::listLink() and Prefs::listLink() (see below).
>>> Alternatively, the descision to show or not show could be moved to the
>>> listLink() methods, but this would result in the same code on 
>>> multiple places.
>>
>> Not much of it, just a check on one setting. Help::listLink() already
>> does this, and it seems like a good solution to me.
>
> OK, so we have
> Help::listLink() for online help
> Prefs::listLink() for options
> ????::listLink() for problems, to which class should we add the listLink for
> problem? Create a new Problem class? (Is naming a class "Problem" asking for
> problems? ;-) )

Okay, you convinced me to put it into the menu class. I'm not sure I like
showLink(), but listLink() doesn't fit all of these and there's no 
place to put
the problem one otherwise. You can probably remove Help::listLink() as part of
this.

> If nobody has any further objections (Jan?) I'll put some effort in it this
> weekend and create a monster patch with all modifications for the 
> framework and all modules. (If we have a verdict on where to place 
> the listLink method for Problem)

Sounds good.

-chuck

--
"Regard my poor demoralized mule!" - Juan Valdez


More information about the dev mailing list