[dev] help/options links

[Roel Gloudemans]

Whew..., I've seen a lot of templates today, but here's the code....

I've splitted the patches into two files
1) menu_code.patch; contains the framework modifications
2) menu_templates; contains all the modified menu.inc files

Cheers,
Roel.

----- Message from chuck at horde.org ---------    Date: Thu, 26 Aug 2004 
16:49:33
-0400    From: Chuck Hagenbuch <chuck at horde.org>Reply-To: Chuck Hagenbuch
<chuck at horde.org> Subject: Re: [dev] help/options links      To:
dev at lists.horde.org

> Quoting Roel Gloudemans <roel at gloudemans.info>:
>
>>>> Showlink is set up in a generic way independent on link type. (Any
>>>> $conf['link']['...'] works. Each link however is set up in a 
>>>> different way.
>>>> Some logic would then have te be added to showLink (showlink then 
>>>> becomes a
>>>> 'gateway' for Help::listLink() and Prefs::listLink() (see below).
>>>> Alternatively, the descision to show or not show could be moved to the
>>>> listLink() methods, but this would result in the same code on 
>>>> multiple places.
>>>
>>> Not much of it, just a check on one setting. Help::listLink() already
>>> does this, and it seems like a good solution to me.
>>
>> OK, so we have
>> Help::listLink() for online help
>> Prefs::listLink() for options
>> ????::listLink() for problems, to which class should we add the listLink for
>> problem? Create a new Problem class? (Is naming a class "Problem" asking for
>> problems? ;-) )
>
> Okay, you convinced me to put it into the menu class. I'm not sure I like
> showLink(), but listLink() doesn't fit all of these and there's no
> place to put
> the problem one otherwise. You can probably remove Help::listLink() 
> as part of
> this.
>
>> If nobody has any further objections (Jan?) I'll put some effort in it this
>> weekend and create a monster patch with all modifications for the 
>> framework and all modules. (If we have a verdict on where to place 
>> the listLink method for Problem)
>
> Sounds good.
>
> -chuck
>
> --
> "Regard my poor demoralized mule!" - Juan Valdez
>
> --
> Horde developers mailing list - Join the hunt: http://horde.org/bounties/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org


----- End message from chuck at horde.org -----


-------------- next part --------------
A non-text attachment was scrubbed...
Name: menu_code.patch
Type: text/x-patch
Size: 11386 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20040829/a07885f6/menu_code-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: menu_templates.patch
Type: text/x-patch
Size: 55811 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20040829/a07885f6/menu_templates-0001.bin