[dev] Re: [cvs] commit: kronolith month.php [patch attached]

Chuck Hagenbuch chuck at horde.org
Mon Nov 29 19:39:55 PST 2004


Quoting "Derek P. Moore" <derekm at hackunix.org>:

> Excellent.  The best of both worlds.  And the implementation is /very/
> clean and simple.

Thanks. :)

> There's one issue with the code as is.  The <img> element will have two title
> attributes if the programmer uses:
>
> Horde::img('icon.png', 'Something', 'title="Do Something Here"');
>
> I'll attempt to integrate grepping of the $attr string for 'title=', 
> if nobody else gets around to it first.

I thought about this and decided not to bother. First of all, this is no
different from before. Second, it would go for alt and src tags, too. So
basically this way of specifying attributes is deprecated, and no code that
previously worked is now broken.

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams


More information about the dev mailing list