[dev] Re: Group class and Datatree

[Jan Schneider]

Zitat von Edward Rudd <erudd at netfor.com>:

> Why exactly is the Horde_Group class tied so closely to the DataTree class?
> Wouldn't it be better to move the public Datatree_Group functions to the
> Horde_Group interface?
>
> example: in horde/admin/group.php the
> $groups->_datatree->get(DATATREE_FORMAT_FLAT, -1, true) is called instead
> of a more generalized $groups->listGroups();  and later
> $groups->_datatree->getParent($groupname) is called instead of calling a
> $groups->getParent($groupname);

No idea. It probably was an oversight or some unfished piece of work. 
Patches to clean this up that don't break BC would be great.

> It would seem a better design to have the Group interface be less tied to
> the Datatree so that full replacement backends can be written easily (in
> my case an LDAP backend for managing groups).

This should actually be done through group hooks.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/