[dev] [cvs] commit: turba browse.php

[Michael Rubinsky]

Two questions about browse.php:

1) Currently, if there are no browseable addressbooks, the select.inc file 
is still included, showing an empty select element.  I wasn't sure if this 
was by design, so I didn't include a fix for that in this last patch.  I 
also wasn't sure if I was missing any cases that would be affected by 
removing the $templates[] = '/browse/select.inc'; line (patch attached).

2) The latest commit fixes a bug that allows a non-browseable source to be 
browsed if it is set as the default.  I currently deal with it using a 
$notification->push() message informing the user that the default 
addressbook is not browseable.  The user can then select another 
addressbook from the addressbook selection menu. (If there are NO 
browseable addressbooks, the user sees a $notification->push() message 
stating that there are no browseable addressbooks).  My question is, should 
we automatically default to the next browseable source in the list, or 
leave as it is now?

Thoughts?

Thanks,
Mike

---------------------------------------------------------------------
List:       horde-cvs
Subject:    [cvs] commit: turba browse.php
From:       "Michael Rubinsky" <mike () theupstairsroom ! com>
Date:       2005-05-12 3:13:55
Message-ID: <20050512031355.0B74E34F9D () coyote ! horde ! org>
[Download message RAW]

mrubinsk    2005-05-11 20:13:55 PDT

  Modified files:
    .                    browse.php
  Log:
  Fixes bug where if no browseable addressbook exists, search results would 
not \
display properly.  Also fixes bug where the browse attribute is ignored for 
a source \
is set as the default in turba prefs, thus allowing a non-browseable 
addressbook to \
be browsed if it was set as default.
  Revision  Changes    Path
  1.86      +8 -6      turba/browse.php

  Chora Links:
  http://cvs.horde.org/diff.php/turba/browse.php?r1=1.85&r2=1.86&ty=u 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browse.diff
Type: application/octet-stream
Size: 226 bytes
Desc: not available
Url : http://lists.horde.org/archives/dev/attachments/20050511/7d6b385c/browse.obj