[dev] [cvs] commit: turba browse.php

[Chuck Hagenbuch]

Quoting Michael Rubinsky <mike at theupstairsroom.com>:

> 1) Currently, if there are no browseable addressbooks, the select.inc 
> file is still included, showing an empty select element.  I wasn't 
> sure if this was by design, so I didn't include a fix for that in 
> this last patch.  I also wasn't sure if I was missing any cases that 
> would be affected by removing the $templates[] = 
> '/browse/select.inc'; line (patch attached).

That makes sense to me, I'd say commit it.

> 2) The latest commit fixes a bug that allows a non-browseable source 
> to be browsed if it is set as the default.  I currently deal with it 
> using a $notification->push() message informing the user that the 
> default addressbook is not browseable.  The user can then select 
> another addressbook from the addressbook selection menu. (If there 
> are NO browseable addressbooks, the user sees a $notification->push() 
> message stating that there are no browseable addressbooks).  My 
> question is, should we automatically default to the next browseable 
> source in the list, or leave as it is now?

I think for now leave it as it is.

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams