[dev] [cvs] commit: imp/lib Compose.php

Chuck Hagenbuch chuck at horde.org
Wed Jun 8 12:28:53 PDT 2005


Quoting Michael M Slusarz <slusarz at mail.curecanti.org>:

> Hmmmm.... Unfortunately, I think this is the same problem as I
> identified here:
> http://bugs.horde.org/ticket/?id=1352

Yes, looks likely.

> Namely, that any fix will break BC.  Such as this one -
> MIME::encodeAddress() previously would not return a PEAR_Error object
> so using Horde 3.0.5 with, say, IMP 4.0.3 is going to be bad.  This was
> the whole reason I haven't done anything further with Bug 1352.
>
> If we want to say fixing the bug is worth breaking BC, that is
> perfectly fine by me.  If that's the case, I will close Bug 1352 then.

Well, I guess the question is if we have any other options. With bug 
2086, perhaps another fix would be to revert the encodeAddress() change 
and to do

if (!$email) ...

after the $email = MIME::encode... line.

But if there is really no other way to fix things, then we may just 
have to selectively break things that should have been checking for the 
error anyway...

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams


More information about the dev mailing list