[dev] Turba groups with nonexistent contacts

Chuck Hagenbuch chuck at horde.org
Wed Jun 22 14:42:06 PDT 2005


Quoting Michael Rubinsky <mike at theupstairsroom.com>:

> Currently, in Object/Group.php, we will prune the entries from the group
> when the entire source itself is not found, but we leave them in when only
> the contact entry is not found when the source is searched.
>
> If the reason for not pruning the groups is to avoid destroying the group
> when the source is temporarily unavailable, doesn't it make more sense to
> not prune the group when the entire source is not found - as would happen
> if someone temp. commented it out in sources.php or accidentally unplugged
> the server ;) and to actually prune the group when the source was found to
> exist, but the contact entry was deleted?  I just hate knowing there is
> 'dead' data sitting in those group entries...

Sure. Work up a patch for it. I'm not feeling as nervous about that 
code as I was earlier...

-chuck

-- 
"But she goes not abroad in search of monsters to destroy." - John 
Quincy Adams


More information about the dev mailing list