[dev] [cvs] commit: kronolith/lib api.php mnemo/lib api.php nag/lib api.php turba/lib api.php

Jan Schneider jan at horde.org
Mon Feb 27 00:19:07 PST 2006


Zitat von Karsten Fourmont <fourmont at gmx.de>:

>   1.66      +31 -6     mnemo/lib/api.php

You added a service entry for 'removeUserData', but no implementation  
for it. And instead of overwriting $GLOBALS['display_notepads'], which  
might have unwanted side effects, you should better extend listMemos()  
to optionally take a notepad (list) as an argument to overwrite  
$display_notepads.

>   1.116     +20 -7     nag/lib/api.php

Though is has no functional effect, you should use a consistent  
default value for the share paramters ('' or null).

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



More information about the dev mailing list