[dev] [cvs] commit: framework/Auth Auth.php framework/Auth/Auth ldap.php framework/Cache Cache.php framework/Compress Compress.php framework/Crypt Crypt.php framework/Data/Data csv.php framework/Editor Editor.php framework/File_PDF PDF.php ...

[Michael Rubinsky]

  > chuck       2006-04-27 19:19:41 PDT
  >
  > Log:
  > Don't silence includes, don't return references where not needed.

Should we be removing the reference from the singleton methods as  
well? I'm getting bunches of reference warnings in the log.



-- 
Thanks,
Mike




-------------- next part --------------
Index: Auth.php
===================================================================
RCS file: /repository/framework/Auth/Auth.php,v
retrieving revision 1.170
diff -u -r1.170 Auth.php
--- Auth.php	28 Apr 2006 02:19:38 -0000	1.170
+++ Auth.php	28 Apr 2006 03:06:00 -0000
@@ -1269,7 +1269,7 @@
      *
      * @return Auth  The concrete Auth reference, or false on an error.
      */
-    function &singleton($driver, $params = null)
+    function singleton($driver, $params = null)
     {
         static $instances = array();
 
@@ -1280,7 +1280,7 @@
 
         $signature = serialize(array($driver, $params));
         if (empty($instances[$signature])) {
-            $instances[$signature] = &Auth::factory($driver, $params);
+            $instances[$signature] = Auth::factory($driver, $params);
         }
 
         return $instances[$signature];