[dev] Proposal for _group_hook

Jan Schneider jan at horde.org
Fri Aug 18 12:32:12 PDT 2006


Zitat von Ben Chavet <ben at horde.org>:

> Quoting Ben Klang <ben at alkaloid.net>:
>
>> On Friday 18 August 2006 12:26, Chuck Hagenbuch wrote:
>>> Quoting Mike Dorman <dorm at dorm.org>:
>>>> Anyone have any thoughts on changing the method for doing group
>>>> hooks to _group_hook($groupName, $userName) instead of
>>>> _group_hook_groupName($userName)?
>>>>
>>>> This will allow for determining which groups have hooks
>>>> programatically, rather than manually having to create the hook for
>>>> each group.
>>>>
>>>> I'm not sure if there is much of a performance implication.  The
>>>> function_exists() call would be for _group_hook, and if it exists
>>>> would then call it.  So I don't think there would be any extra
>>>> function calls.
>>>
>>> This does make sense to me. Ben, Jan, other people who use complicated
>>> groups setups - any problems here?

Not at all, I never understood the rationale for the current implementation.

>> I concur, except for one question:  if we're using the group name we need to
>> make sure the full group path is passed.  Otherwise it may be ambiguous.
>>
>> /BAK/
>
> Or, use the group ID, like we do everywhere else.

I think group names are much more intuitive, especially if you want to  
use the hook to tie into a legacy group backend that obviously doesn't  
know about group IDs.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



More information about the dev mailing list