[dev] Prefs rewrite in HEAD
Chuck Hagenbuch
chuck at horde.org
Wed Nov 22 20:50:47 PST 2006
For those of you who don't read the commits list:
I need people who use HEAD to test this out. I'm pretty confident that
SQL prefs are working appropriately, but LDAP prefs, IMSP prefs (not
sure they could have worked before, I fixed some typos there), and
also things like hooks. Please let me know how this works for you.
Thanks!
----- Forwarded message from chuck at horde.org -----
Date: Wed, 22 Nov 2006 20:47:04 -0800 (PST)
From: Chuck Hagenbuch <chuck at horde.org>
Reply-To: dev at lists.horde.org
Subject: [cvs] commit: horde/docs CHANGES horde/config
prefs.php.dist framework/Horde/Horde Registry.php framework/Prefs
Identity.php Prefs.php framework/Prefs/Prefs imsp.php ldap.php
session.php sql.php
To: cvs at lists.horde.org
chuck 2006-11-22 20:47:04 PST
Modified files:
docs CHANGES
config prefs.php.dist
Horde/Horde Registry.php
Prefs Identity.php Prefs.php
Prefs/Prefs imsp.php ldap.php session.php sql.php
Log:
[cjh] Rewrite the Prefs code to keep the same Prefs object through multiple
scope changes, instead of re-loading the Horde prefs, or prefs for
a scope that had already been loaded. Fixes bugs when making changes
to preferences and then switching scopes again (Bug #2838).
This is a big change to the prefs system, and while I've tested all of
it as best as I can, and the SQL driver I'm pretty confident in, this
needs testing before we even think about merging it. It would all be
BC, though.
Please let me know (or update the bug) if this works or doesn't work
for you, especially people using lots of hooks and other more edge
cases, and also let me know if you think it should be merged or not.
Revision Changes Path
1.289 +8 -7 framework/Horde/Horde/Registry.php
1.5 +9 -18 framework/Prefs/Identity.php
1.181 +172 -154 framework/Prefs/Prefs.php
1.14 +70 -92 framework/Prefs/Prefs/imsp.php
1.111 +70 -128 framework/Prefs/Prefs/ldap.php
1.41 +12 -37 framework/Prefs/Prefs/session.php
1.122 +92 -147 framework/Prefs/Prefs/sql.php
1.103 +13 -5 horde/config/prefs.php.dist
1.893 +4 -0 horde/docs/CHANGES
Chora Links:
http://cvs.horde.org/diff.php/framework/Horde/Horde/Registry.php?r1=1.288&r2=1.289&ty=u
http://cvs.horde.org/diff.php/framework/Prefs/Identity.php?r1=1.4&r2=1.5&ty=u
http://cvs.horde.org/diff.php/framework/Prefs/Prefs.php?r1=1.180&r2=1.181&ty=u
http://cvs.horde.org/diff.php/framework/Prefs/Prefs/imsp.php?r1=1.13&r2=1.14&ty=u
http://cvs.horde.org/diff.php/framework/Prefs/Prefs/ldap.php?r1=1.110&r2=1.111&ty=u
http://cvs.horde.org/diff.php/framework/Prefs/Prefs/session.php?r1=1.40&r2=1.41&ty=u
http://cvs.horde.org/diff.php/framework/Prefs/Prefs/sql.php?r1=1.121&r2=1.122&ty=u
http://cvs.horde.org/diff.php/horde/config/prefs.php.dist?r1=1.102&r2=1.103&ty=u
http://cvs.horde.org/diff.php/horde/docs/CHANGES?r1=1.892&r2=1.893&ty=u
--
To unsubscribe, mail: cvs-unsubscribe at lists.horde.org
----- End forwarded message -----
-chuck
--
"we are plastered to the windshield of the bus that is time." - Chris
More information about the dev
mailing list