[dev] [cvs] commit: framework/devtools horde-js-compress.php

Michael M Slusarz slusarz at horde.org
Wed May 2 19:25:44 UTC 2007


Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Michael M Slusarz <slusarz at horde.org>:
>
>>   Log:
>>   Readd check for jsmin in devtools and use the location of the found jsmin.
>
> This will never work except if you're running horde-js-compress.php
> directly from the framework location, which isn't the general use
> case. If you need this, can you add a check to make sure that
> dirname(__FILE__) . '/jsmin/jsmin' actually exists?

That's what we do:
$jsmin = trim(`which jsmin`);
if (empty($jsmin)) {
     $jsmin = dirname(__FILE__) . "/jsmin/jsmin";
}

...and later...

if (!$usephp && file_exists($rhino) && file_exists($jsmin)) {

michael



More information about the dev mailing list