[dev] [cvs] commit: horde test.php

Jan Schneider jan at horde.org
Fri Jul 27 16:02:43 UTC 2007


Zitat von Chuck Hagenbuch <chuck at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> No, we only have our own version of File/CSV.php, we still need
>> File.php from the File package.
>
> As far as I can tell, the only thing that we use File.php for is for
> the FILE_MODE_* constants. If that's it, let's just have our own
> constants in CSV.php and remove the dependency. Having a forked
> File_CSV but requiring people to install the File package leads to
> problems with the order of includes sometimes (and if it's happened to
> me, I'm sure it's tripped up others. :)

Fine for me. It was used in translation.php too, but I seem to have  
replaced it at some point in the past.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



More information about the dev mailing list