[dev] [cvs] commit: framework/Image/Image/Decorator watermark.php

[Michael Rubinsky]

Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Michael Rubinsky <mike at theupstairsroom.com>:
>
>>   Removed files:
>>     Image/Image/Decorator watermark.php
>>   Log:
>>   watermark is implemented in each concrete class - remove the
>> Decorator_watermark class
>
> The intention was to go the other way here, since watermark is another
> thing that I don't see being on the same level of line(), circle(),
> etc...

Wouldn't removing it from the api break bc though?

Plus, (for watermark in particular) the imagick specific code (not  
commited yet but basically the same idea as described on Mikko's   
blog) would be more resource intensive if we had to do it all through  
Horde_Image calls, as it would require creating seperate Horde_Images,  
then composing them together...not that it couldn't be done but...

Driver specific decorators with maybe a decorator factory method in  
the concrete class might be helpful here - or am I getting too  
complicated (as usual)? :)


Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org

"Time just hates me. That's why it made me an adult." - Josh Joplin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: PGP Digital Signature
Url : http://lists.horde.org/archives/dev/attachments/20071017/bc111a65/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2013 bytes
Desc: PGP Public Key
Url : http://lists.horde.org/archives/dev/attachments/20071017/bc111a65/attachment-0001.bin