[dev] [cvs] commit: horde/services/portal index.php

[Michael Rubinsky]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael Rubinsky <mike at theupstairsroom.com>:
>
>> mrubinsk    2007-11-22 13:38:28 EST
>>
>>   Modified files:
>>     services/portal      index.php
>>   Log:
>>   Horde_Block_Collection::getFixedBlocks() returns a serialized
>> array - we need an unserialized array here.
>
> Our changes don't make sense then. I could have sworn that
> getFixedBlocks() is *not* returning a serialized array, thus all my
> changes. Dumb me.
>
> I still think that it makes more sense to pass arrays around APIs than
> serialized arrays, so instead of serializing and unserializing them,
> getFixedBlocks() should return the plain array.

I agree, but wasn't 100% sure if that would break anything else...I'll  
revert then unserialize it in the api and see where that leads...


Happy T-Day for those that celebrate it :)

Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org

"Time just hates me. That's why it made me an adult." - Josh Joplin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-keys
Size: 2013 bytes
Desc: PGP Public Key
Url : http://lists.horde.org/archives/dev/attachments/20071122/757ed9bb/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: PGP Digital Signature
Url : http://lists.horde.org/archives/dev/attachments/20071122/757ed9bb/attachment-0001.bin