[dev] [cvs] commit: genie list.php genie/config types.php.dist genie/lib Driver.php Genie.php genie/templates/item item.inc genie/templates/list item_headers.inc items.inc

[Jan Schneider]

Zitat von Duck <duck at obala.net>:

> duck        2007-11-30 05:20:14 EST
>
>   Modified files:
>     .                    list.php
>     lib                  Driver.php Genie.php
>     templates/item       item.inc
>     templates/list       item_headers.inc items.inc
>   Added files:
>     config               types.php.dist
>   Log:
>   Add basic item type definition

It's good that we finally have a way to specify product types at all,  
though I wonder if we could come up with a solution that doesn't  
require yet another configuration file. Prefs come to mind. They are  
not optimal because you end up loading the prefs for any user that you  
display the wishlist for. But it's still the most flexible solution,  
and we can't provide hashes with conf.xml.

Then again I wonder if the types are necessary at all, since you could  
do the same with categories which already work fine with a mixed user  
environment.

Also, same here, check that you are not deleting a safeguard to keep  
users from modifying other users' times. Better not mix commits that  
are not related at all.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/