[dev] Bug when adding exemptions to recurring events

John Morrissey jwm at horde.net
Sun Jan 13 18:57:19 UTC 2008


When using the Delete link in the kronlith summary block to remove a single
recurrence of an event, I noticed an exception was being added for the
current day instead of the day of the event (the event I clicked the Delete
link for). No timestamp was being emitted in the link being generated by the
block. This patch fixes it, but committing it out-of-hand makes me nervous
since it seems odd that a null timestamp would be explicitly passed in the
first place. Thoughts?

Index: summary.php
===================================================================
RCS file: /repository/kronolith/lib/Block/summary.php,v
retrieving revision 1.41.2.8
diff -u -u -r1.41.2.8 summary.php
--- summary.php	20 Dec 2007 14:12:34 -0000	1.41.2.8
+++ summary.php	13 Jan 2008 18:57:24 -0000
@@ -194,7 +194,7 @@
                     $event->end->timestamp() > $now) {
                     $html .= '<strong>';
                 }
-                $html .= $event->getLink(null, true);
+                $html .= $event->getLink($event->start->timestamp(), true);
                 if ($event->start->timestamp() < $now &&
                     $event->end->timestamp() > $now) {
                     $html .= '</strong>';

john
-- 
John Morrissey          _o            /\         ----  __o
jwm at horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__


More information about the dev mailing list