[dev] [cvs] commit: framework/Share/Share sql.php

Jan Schneider jan at horde.org
Fri Jun 6 16:09:18 UTC 2008


Zitat von "Michael Rubinsky" <mike at theupstairsroom.com>:

> Quoting "Jan Schneider" <jan at horde.org>:
>
>> jan         2008-06-06 06:50:14 EDT
>>
>>  Modified files:
>>    Share/Share          sql.php
>>  Log:
>>  $data['perm'] is not set here, so don't try to unset it.
>
> I might be missing something here, but wouldn't it also be  
> unnecessary  to perform the isset($data['perm']['users']) and   
> isset($data['perm']['groups']) checks in that block as well?  Want  
> to  make sure I'm thinking about that conditional correctly :)

True, I didn't notice those.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



More information about the dev mailing list