[dev] [cvs] commit: kronolith/js embed.js kronolith/js/src embed.js kronolith/themes embed.css

[Michael Rubinsky]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael Rubinsky <mrubinsk at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> Zitat von Michael Rubinsky <mike at theupstairsroom.com>:
>>>
>>>> mrubinsk    2008-08-20 20:21:27 EDT
>>>>
>>>> Modified files:
>>>>  js                   embed.js
>>>>  js/src               embed.js
>>>>  themes               embed.css
>>>> Log:
>>>> Some slightly modified ToolTip code to allow it to play nice with  
>>>>  other websites
>>>> since this code will be embedded on external sites.
>>>
>>> Is there a reason this can't be done globally in Horde? Since   
>>> tooltip generation is encapsulated in Horde:: there shouldn't be  
>>> any  requirements for the application code.
>>
>> That was my initial plan, especially since Ansel is going to need   
>> similar code.  I did it like this for 2 reasons.
>> 1) This allows it to work with current H3 code, but I guess we can   
>> make Horde 3.2.2 a requirement for this feature in Krono?
>
> Yes. Or have tooltips fail in widgets if not using Horde 3.2.2.  
> Though I still don't see why it fails.

It doesn't totally fail, but they don't get formatted. i.e. you see  
something like <pre>This is an important event<br />....</pre> etc...


>> 2) Currently, this code needs to be run after *all* the widgets are  
>>  processed and loaded in the DOM since the <a> elements don't exist  
>>  until after window load.  The way the code is currently, we can't   
>> guarantee the order that widgets from all Horde applications are   
>> loaded since they can appear anywhere on the embedded page. That  
>> being  said, it could (and probably should) be refactored to only  
>> process our  widgets' elements instead of the whole page anyway, so  
>> I'll take a  look at making this possible...probably by not firing  
>> it onload, but  instead processing the <a> elements as they are  
>> created.
>
> But isn't onload only fired if all <script> elements have been  
> loaded and executed? Or are the widgets created onload too?

Yes, they are inserted into the DOM onload.


Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org

"Time just hates me. That's why it made me an adult." - Josh Joplin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: PGP Digital Signature
URL: <http://lists.horde.org/archives/dev/attachments/20080821/01a062d4/attachment.bin>