[dev] Horde_Imap_Client vs. Horde_Imap_Client_Base

[Chuck Hagenbuch]

Quoting Michael M Slusarz <slusarz at horde.org>:

>> Quoting Chuck Hagenbuch <chuck at horde.org>:
>>
>>> Is there a reason not to move the methods in horde_imap_client to
>>> horde_imap_client_base, and remove one parent class from the hierarchy?
>>
>> No.  That was the way *you* had originally set it up, so I thought
>> that maybe you had some good reason for it :)

Whoops. Well, I learn things all the time. :)

> After making the changes, I realized the reason... there are several
> functions we need to be able to call statically from
> Horde_Imap_Client.  However, Horde_Imap_Client_Base contains a whole
> bunch of abstract functions.  Those 2 don't mix.  Merging the files is
> totally possible (I have done so on a local branch already)... we just
> have to remove all abstract declarations.  Don't know if this is
> desirable or not.  If OK, let me know - I have already done the
> necessary work and will re-apply the changes (yay git!) and commit.

I've got an alternate solution which I'm about to push, which is to  
move those static functions into a utility class, that can then be  
shared, tested, etc. I think the abstracts that are there are  
reasonable - take a look at what I'm pushing, let me know if you don't  
like it (and if so, why <g>).

-chuck