[dev] Horde_Imap_Client vs. Horde_Imap_Client_Base

[Michael M Slusarz]

Quoting Chuck Hagenbuch <chuck at horde.org>:

>> After making the changes, I realized the reason... there are several
>> functions we need to be able to call statically from
>> Horde_Imap_Client.  However, Horde_Imap_Client_Base contains a whole
>> bunch of abstract functions.  Those 2 don't mix.  Merging the files is
>> totally possible (I have done so on a local branch already)... we just
>> have to remove all abstract declarations.  Don't know if this is
>> desirable or not.  If OK, let me know - I have already done the
>> necessary work and will re-apply the changes (yay git!) and commit.
>
> I've got an alternate solution which I'm about to push, which is to
> move those static functions into a utility class, that can then be
> shared, tested, etc. I think the abstracts that are there are
> reasonable - take a look at what I'm pushing, let me know if you don't
> like it (and if so, why <g>).

Looks fine to me.  At this point - if it works, I approve :)

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]