[dev] [cvs] commit: gollem login.php gollem/docs CHANGES

[Michael Rubinsky]

Let's try replying to this again, with the correct identity...

Quoting Chuck Hagenbuch <chuck at horde.org>:

> Quoting Michael Rubinsky <mike at theupstairsroom.com>:
>
>>  Log:
>>  Make sure that the backend_key parameter is not hidden with the url
>> parameter.
>>
>>  This would happen if being redirected here via a
>> authenticationFailureRedirect
>>  and could cause the wrong backend to be selected if more than one
>> backend is
>>  configured.
>
>>  Can another dev sanity check me?
>
>> http://cvs.horde.org/diff.php/gollem/login.php?rt=horde&r1=1.127&r2=1.128&ty=u
>
> This doesn't seem right to me. Shouldn't we just pass the parameter  
> correctly in the first place?

Ideally, yes.  Though I don't see how to do that while going through  
Horde::authenticationFailureRedirect() - unless we're talking about  
giving Gollem it's own version of that method.


Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org

"Time just hates me. That's why it made me an adult." - Josh Joplin