[dev] [commits] Horde-Hatchery branch master updated.
Jan Schneider
jan at horde.org
Mon Jun 8 08:36:12 UTC 2009
Zitat von Michael Rubinsky <mrubinsk at horde.org>:
>
> Quoting Jan Schneider <jan at horde.org>:
>
>> Zitat von Michael Rubinsky <mike at theupstairsroom.com>:
>>
>>> Attempt to get a good weatherdotcom location string from Turba's
>>> 'own' contact
>>>
>>> timeobjects/lib/Driver/Weather.php | 153
>>> ------------------------------
>>> timeobjects/lib/Driver/Weatherdotcom.php | 16 +++-
>>> 2 files changed, 14 insertions(+), 155 deletions(-)
>>> delete mode 100644 timeobjects/lib/Driver/Weather.php
>>>
>>> http://git.horde.org/diff.php/timeobjects/lib/Driver/Weather.php?rt=horde-hatchery&r1=65b7252e2bf34a2424bf00d5e9d72240a02afaac&r2=2a53d957d3e4c041d7c2c70fb88f2c3d0d9d2c25
>>> http://git.horde.org/diff.php/timeobjects/lib/Driver/Weatherdotcom.php?rt=horde-hatchery&r1=1a712bb64f7c9cb8abd5cd4c539a424da79ef11f&r2=2a53d957d3e4c041d7c2c70fb88f2c3d0d9d2c25
>>
>> There exists an API method for that purpose in Turba.
>
> The only existing method I saw was getOwnVCard(), which returns the
> contact as, well, as vCard ;)
>
> Am I missing another method?
Ah, no. I didn't remember that this was returning as vCard. I guess it
makes sense to make this a more generic method, like export(), as that
it takes a parameter specifying the requested format. OTOH this is not
a very strict i.e. good API.
Maybe it makes more sense to accompany the existing method with an
ownContact() method returning a hash.
Jan.
--
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.horde.org/archives/dev/attachments/20090608/c946cda3/attachment.bin>
More information about the dev
mailing list