[dev] [cvs] commit: framework/Horde Horde.php

[Michael Rubinsky]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Michael Rubinsky <mrubinsk at horde.org>:
>
>>> slusarz     2009-06-29 01:42:05 EDT
>>>
>>> Modified files:
>>>  Horde                Horde.php  Log:
>>> Move RFC 2397 generation code from IMP to Horde.
>>> Revision  Changes    Path
>>> 1.723     +25 -4     framework/Horde/Horde.php
>>
>> This breaks any place where we pass a fully qualified url to  
>> Horde::img() as the $src.
>
> From what I know about Horde::img(), this is incorrect usage.  The  
> whole reason to use img() is to automatically generate images based  
> on the current registry values (in other words, img() is designed to  
> create links to images that live in either that app's or horde's  
> themes/ directory).  If you have a fully qualified URL, what's the  
> point in using img()?  Instead, the image should simply be directly  
> output.  img() is not designed as a shortcut to creating a HTML  
> <img> tag.

Yea, I figured as much. I know I've been using it as a img tag  
generator for a while, and I've been getting lots of weird file paths  
because of it now. I'll track down where it's used like that and  
simple build the img tag string manually...at least until we start  
using Horde_View and it's helpers more :)


Thanks,
mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org

"Time just hates me. That's why it made me an adult." - Josh Joplin