[dev] [cvs] commit: framework/Horde Horde.php

Michael M Slusarz slusarz at horde.org
Mon Jun 29 18:00:37 UTC 2009


Quoting Michael Rubinsky <mrubinsk at horde.org>:

> Quoting Michael M Slusarz <slusarz at horde.org>:
>
>> From what I know about Horde::img(), this is incorrect usage.  The  
>> whole reason to use img() is to automatically generate images based  
>> on the current registry values (in other words, img() is designed  
>> to create links to images that live in either that app's or horde's  
>> themes/ directory).  If you have a fully qualified URL, what's the  
>> point in using img()?  Instead, the image should simply be directly  
>> output.  img() is not designed as a shortcut to creating a HTML  
>> <img> tag.
>
> Yea, I figured as much. I know I've been using it as a img tag  
> generator for a while, and I've been getting lots of weird file  
> paths because of it now. I'll track down where it's used like that  
> and simple build the img tag string manually...at least until we  
> start using Horde_View and it's helpers more :)

Yeah - I have no problem working towards a Horde_View solution but 1.)  
that solution isn't production-viable yet and 2.) the code in Horde::  
can/will be pretty much be adopted in Horde_View anyway.

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]



More information about the dev mailing list