[dev] WebDAV/CalDAV integration - first questions

Chuck Hagenbuch chuck at horde.org
Sat Sep 26 03:43:56 UTC 2009


Quoting Evert Pot <evertpot at gmail.com>:

> If you're set on using the rpc system for this, I would suggest  
> removing the following lines from rpc.php:
>
> /* Return the response to the client. */
> header('Content-Type: ' . $server->getResponseContentType());
> header('Content-length: ' . strlen($out));
> header('Accept-Charset: UTF-8');
> echo $out;
>
> ..and let the various RPC classes be responsible for both HTTP  
> headers, and any output. It would be easy to just copy these lines  
> to the abstract RPC class, so transition is seamless.
> SabreDAV also needs to be responsible for the Content-Length header,  
> because the size of $out does not match the Content-Length header  
> when a GET request with a Range: header is made, or when an HTTP  
> HEAD request is made.
>
> I could add an output(); method for example..

I'd be in favor of this. It also seems like a good step towards having  
Rpc/Dav controllers, instead of the current single-entry point system.

In other words, I'd help you with this if you started a patch.

Thanks!

-chuck


More information about the dev mailing list