[dev] [commits] Horde branch master updated. 6d97c196be61e3bca4413767f7b6f4d12b62fefd

[Michael M Slusarz]

Quoting Jan Schneider <jan at horde.org>:

> Zitat von Michael M Slusarz <slusarz at horde.org>:
>
>> Quoting Jan Schneider <jan at horde.org>:
>>
>>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>>
>>>> daf7a5e Added Horde_Util::convertToUtf8().
>>>
>>> This should be in Horde_String.
>>
>> I'm not sure I agree.  This function does not necessarily work on  
>> strings - i.e. you can pass an object to convertToUtf8() and it  
>> will return an object.  All the rest of the Horde_String functions  
>> are solely related to string data only (they either return string  
>> data or, for length(), it accepts string data).
>
> This is not true, Horde_String::convertCharset() already converts  
> objects and arrays too, and it also has a shortcut for converting to  
> UTF-8 using utf_endcode(). So Horde_Util::convertToUtf8() is really  
> just a subset of the Horde_String::convertCharset() functionality  
> and thus duplicating code.

I've moved convertToUtf8() to Horde_String::.

michael

-- 
___________________________________
Michael Slusarz [slusarz at horde.org]