[dev] [commits] Horde branch master updated. 3af9c55c8151d96dae79facb7272f40f0907bfe3

Michael Rubinsky mrubinsk at horde.org
Sun Apr 11 14:31:41 UTC 2010


Quoting Michael M Slusarz <slusarz at horde.org>:

> The branch "master" has been updated.
> The following is a summary of the commits.
>
> from: 9fc391d83bad2e00b3a72c48e70d169362a5f54f
>
> 4e3770e Need to push app on stack earlier to prevent loop
> 3af9c55 Consolidate code run when switching applications

These commits, along with the previous one  
(9fc391d83bad2e00b3a72c48e70d169362a5f54f) defeat the purpose of the  
changes I made in Horde's Horde_Api::getPreference() api method.  By  
pushing AND popping the application entirely in  
Horde_Registry#loadPrefs, then the preference that you are trying to  
read is no longer available when the method exits. In other words, in  
Horde_Api::getPreference(), when $GLOBALS['prefs']->getValue() is  
called, the application whose preference you are trying to read is no  
longer on the stack, and the preference is no longer available.

-- 
Mike

--
The Horde Project (www.horde.org)
mrubinsk at horde.org

"Reality is merely an illusion, albeit a very persistent one." - A. Einstein


More information about the dev mailing list