[dev] [commits] Horde branch master updated. 8d899d2a9375471e7ef8620515281ebb673f0f1e

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Michael Rubinsky <mrubinsk at horde.org>:
>
>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>
>>> We should not need the Datatree-related stuff anymore, right?  It  
>>> has been deprecated and is no longer an option under horde/config.
>>
>> My understanding was that we might still need the code for upgrade  
>> related tasks...maybe I misunderstood?
>
> You are probably right.  But I also doubt we need all of the code in  
> the Driver to do this upgrade.  The issue will be that we have to  
> maintain that much more code in H4 that is essentially dead.
>
> IMHO, it would make sense to rip out all code required for  
> conversion and put it into an upgrade script rather than a library.
>
> The Datatree package itself is a little more difficult - obviously,  
> the core components will be used by other scripts when doing  
> conversions.  But I don't think we should continue to maintain a  
> package for it, considering it is 100% deprecated.  Again, maybe rip  
> out whatever is needed to upgrade and move it somewhere globally  
> available, but no longer its old package (horde/Support?  
> horde/Upgrade?)

I don't see an issue with keeping the package around, but not using it  
anywhere outside of the upgrade scripts.
Whether we leave the code where it is, or strip it, or move it  
somewhere else, we still have to maintain it, theoretically. In  
practice, we probably won't have to touch the code anymore at all. At  
least if we leave as it is. The more we change it now, the higher  
chances are we break it, and have to fix bugs of this dead code. IMO  
we don't have to convert it to H4 standars either, as long as it works  
from the upgrade scripts.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/