[dev] [commits] Horde branch master updated. e72224111a21c01ac1587478f8597e932caf0470

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Chuck Hagenbuch <chuck at horde.org>:
>
>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>
>>> Quoting Chuck Hagenbuch <chuck at horde.org>:
>>>
>>>> Quoting Michael M Slusarz <slusarz at horde.org>:
>>>>
>>>>> Quoting Chuck Hagenbuch <chuck at horde.org>:
>>>>>
>>>>>> commit 3c2ef042ab5879f74472eda10c12941e8e8035ca
>>>>>> Author: Chuck Hagenbuch <chuck at horde.org>
>>>>>> Date:   Sat Oct 2 17:05:56 2010 -0400
>>>>>>
>>>>>> Add SyntaxHighlighter viewer
>>>>>>
>>>>>> framework/Mime_Viewer/lib/Horde/Mime/Viewer/SyntaxHighlighter.php |   
>>>>>> 222 +++++
>>>>>> 1 files changed, 222 insertions(+), 0 deletions(-)
>>>>>> create mode 100644  
>>>>>> framework/Mime_Viewer/lib/Horde/Mime/Viewer/SyntaxHighlighter.php
>>>>>>
>>>>>> http://git.horde.org/co.php/framework/Mime_Viewer/lib/Horde/Mime/Viewer/SyntaxHighlighter.php?rt=horde-git&r=3c2ef042ab5879f74472eda10c12941e8e8035ca
>>>>>
>>>>> Might be jumping the gun here, but this can't live in the  
>>>>> horde/Mime_Viewer package.  Needs to live in horde/Core instead.
>>>>
>>>> Because of the javascript? What if we bundle it in Mime_Viewer,  
>>>> like the editor javascript?
>>>
>>> horde/Mime_Viewer is completely independent of horde/Core. (Well,  
>>> not exactly true.  Doing a grep there is one Horde::externalUrl()  
>>> call that needs to be removed...)
>>>
>>> You could package this js code in Mime_Viewer, but we are still  
>>> going to need a wrapper in Core to add the javascript to the  
>>> output page (e.g. the Horde::addInlineScript() and  
>>> Horde::addScriptFile() calls).  This is similar to why we need  
>>> Horde_Core_Mime_Viewer_Css, for example.
>>
>> Ah, k. How about now? :)
>
> The Core stuff looks good.  However, the Horde:: calls still remain  
> in the Mime_Viewer version.  I'm guessing the best way to handle  
> this is to require the path to the javascript files in the base  
> driver - since it would be the implementers burden to set up the web  
> server paths.
>
> Also, with this commit I am assuming that javascript is pretty much  
> mandatory now, at least for mainline Horde apps?

No, we've discussed this a lot during the meeting, and decided for  
this specific case that we want to favour it over a server based GeSHi  
or Text_Highlighter solution.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/