[dev] [commits] Horde branch master updated. 062155700ae928aa4ce65a7b01aaf1930b0cfaed

Chuck Hagenbuch chuck at horde.org
Mon Oct 11 02:27:43 UTC 2010


Quoting "Michael J.Rubinsky" <mrubinsk at horde.org>:

> I started working on this locally, but want to be sure I understand  
> fully now that I've removed a few of these:
>
> So, for example, the Horde_Compress package (which we don't have a  
> core factory for), currently has a factory() method. There's no  
> rocket science in the method, just the typical add $driver name to  
> __CLASS__ and pass $params  etc... There is nothing really  
> configuration specific here, so these type of factories could move  
> to Horde_Compress_Factory::create()?  While packages such as  
> Horde_Auth, while still containing no core dependencies, requires  
> setup that is so specific to the client code that we should totally  
> remove the factory code and instead require the client code to deal  
> with it.
>
> I just worry about consistency across packages for object creation,  
> but I guess that would be dealt with by documentation.

Yeah.. for non-framework usage, if these classes are so simple to  
create, why not just instantiate them?

$foo = new Horde_Token_Sql(), for example.

-chuck


More information about the dev mailing list