[dev] [commits] Horde branch master updated. bb85601da508e3272d0f9bda00310c28f278e86c

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>
>>> Quoting Jan Schneider <jan at horde.org>:
>>>
>>>> Zitat von Michael M Slusarz <slusarz at horde.org>:
>>>>
>>>>> Quoting Jan Schneider <jan at horde.org>:
>>>>>
>>>>>> commit bb85601da508e3272d0f9bda00310c28f278e86c
>>>>>> Author: Jan Schneider <jan at horde.org>
>>>>>> Date:   Wed Mar 30 18:08:02 2011 +0200
>>>>>>
>>>>>> Show full alarm notifications in dynamic view (Request #9748).
>>>>>>
>>>>>> imp/docs/CHANGES                       |    1 +
>>>>>> imp/js/dimpcore.js                     |   73  
>>>>>> ++++++++++++++++++++++++++++---
>>>>>> imp/package.xml                        |    2 +
>>>>>> imp/templates/dimp/javascript_defs.php |    8 ++++
>>>>>> 4 files changed, 77 insertions(+), 7 deletions(-)
>>>>>>
>>>>>> http://git.horde.org/horde-git/-/commit/bb85601da508e3272d0f9bda00310c28f278e86c
>>>>>
>>>>> Shouldn't this be something abstracted out into Horde and/or  
>>>>> Core?  Looks like this code is pretty much copied/pasted from  
>>>>> kronolith.
>>>>
>>>> Exactly. Like more than 50% of any code in dimpcore/base.js,  
>>>> kronolith.js, hermes.js. For Horde 5 we should clean this up and  
>>>> create an abstract js library for all ajax apps.
>>>
>>> But any reason why we shouldn't be doing it now?  Especially since  
>>> the alarm notification js is presumably stable since it has been  
>>> used in kronolith for awhile?
>>
>> Because I rather don't want to make any larger changes like moving  
>> code around 5 days before the final releases.
>
> I thought the official release was pushed back towards the middle of  
> April?  I personally don't believe that we are going to be ready for  
> a stable release on the 5th.  I know I still have a long list of  
> todos/bugfixes to work through that won't be completed by next  
> Tuesday.

No, what made you think we shifted the release date? April 5th is set.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/