[dev] [commits] Horde branch master updated. 273ee9009dbfb88d925bcf459648270291cab48c

[Michael J Rubinsky]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting "Michael J. Rubinsky" <mrubinsk at horde.org>:
>
>> commit 3a6dae7dab4c44fce7e283bd0c0ed4489808851a
>> Author: Michael J Rubinsky <mrubinsk at horde.org>
>> Date:   Mon May 23 18:05:00 2011 -0400
>>
>>    Bug: 10050 Don't remove tmp image file at request shutdown.
>>
>>    Commit 9fd6579fa7b1e1a920601c3f9517c1fd18a84c0e broke the existing
>>    behavior of not removing the temporary file. This restores that
>>    functionality. Not sure if this is the final fix for this, as this
>>    causes tmp image files to build up in the temporary directory. However,
>>    this was the previous behavior and should be the admin's job to perform
>>    gc on temp directory periodically anyway.
>>
>> turba/lib/Object.php |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> If data *must* persist beyond a single access, we should never be  
> using temp files.  We must use some sort of permanent storage  
> solution instead (e.g. VFS; see., e.g., compose attachment data in  
> IMP).  Anything else is attempting to use temp files in a manner not  
> intended in the original design.

I agree, which is why I indicated that this probably isn't the final  
fix. However, this simply reverts back to the behavior that has  
existed since the photo field form type was originally implemented.  
VFS isn't a viable option without (1) rewriting Horde_Form's handling  
of the photo field and (2) requiring a VFS for the photo field to even  
work at all. Both of which are BC breaks.

This commit gets the photo field functionality back into the 3.0.x  
series. We can revisit this for Horde 5.

-- 
mike

The Horde Project (www.horde.org)
mrubinsk at horde.org