[dev] [commits] Horde branch develop updated. 697b4783bddf3068cec8fe3fb26ec49cb8d19c60

[Jan Schneider]

Zitat von Ralf Lang <lang at b1-systems.de>:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 02.04.2012 12:37, schrieb Ralf Lang:
>> The branch "develop" has been updated. The following is a summary
>> of the commits.
>>
>> from: fce8fb379a7d0916e3c647083093116068513419
>>
>> 697b478 Add an optional factory to externalize creation of
>> "related" mappers
>>
>> -----------------------------------------------------------------------
>>
>>  commit 697b4783bddf3068cec8fe3fb26ec49cb8d19c60 Author: Ralf Lang
>> <lang at b1-systems.de> Date:   Mon Apr 2 12:36:04 2012 +0200
>>
>> Add an optional factory to externalize creation of "related"
>> mappers
>>
>> framework/Rdo/lib/Horde/Rdo/Base.php    |    6 ++-
>> framework/Rdo/lib/Horde/Rdo/Factory.php |   66
>> +++++++++++++++++++++++++++++++
>> framework/Rdo/lib/Horde/Rdo/Mapper.php  |   29 +++++++++++++- 3
>> files changed, 99 insertions(+), 2 deletions(-) create mode 100644
>> framework/Rdo/lib/Horde/Rdo/Factory.php
>>
>> http://git.horde.org/horde-git/-/commit/697b4783bddf3068cec8fe3fb26ec49cb8d19c60
>>
>>
>>
>
> This is a renamed and slightly adapted version of an Rdo enhancement I
> used in a Horde 4 project. It speeded up an application which heavily
> relied on relations. It should not break any existing code.

- The factory method should be called create() like we do in H4-style  
injector factories.
- attachCache() is an unintuitive method name, especially since this  
doesn't have anything to do with caching - the factory you use happens  
to cache internally, but that's irrelevant for Horde_Rdo_Mappper.  
setFactory() makes more sense, or pass the factory right to the  
constructor.
- There are some vertical whitespace issues and missing phpdoc in  
Factory.php and phdoc alignment issues in attachCache().

-- 
Jan Schneider
The Horde Project
http://www.horde.org/