[dev] [commits] Horde branch develop updated. 697b4783bddf3068cec8fe3fb26ec49cb8d19c60

[Ralf Lang]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> - The factory method should be called create() like we do in
> H4-style injector factories. - attachCache() is an unintuitive
> method name, especially since this doesn't have anything to do with
> caching - the factory you use happens to cache internally, but
> that's irrelevant for Horde_Rdo_Mappper. setFactory() makes more
> sense, or pass the factory right to the constructor.

Right, this is a leftover from the original project where the class
was named Horde_Rdo_Cache. I'll fix thi.


> - There are some vertical whitespace issues and missing phpdoc in 
> Factory.php and phdoc alignment issues in attachCache().



- -- 
Ralf Lang
Linux Consultant / Developer
Tel.: +49-170-6381563
Mail: lang at b1-systems.de

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk95jOQACgkQCs1dsHJ/X7Cu5gCdHAj9Q9nRpt4fokilnjpW6sxB
RDYAnRvgLuiLuQcQrFbUbilm/dt2ji+u
=nMBe
-----END PGP SIGNATURE-----