[dev] Imple rewrite issues

[Michael J Rubinsky]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Michael J Rubinsky <mrubinsk at horde.org>:
>
>> I wasn't planning on looking at any of this now, but it's  
>> interfering with my normal workflow now so I've started looking at  
>> things enough to fix what I need. I fixed a few issues I was having  
>> that was preventing the portal page from loading fully when the  
>> Mnemo Notes block or the Weather block are present. I've also fixed  
>> a few issues with Kronolith's traditional view sidebar.
>>
>> The tagging functionality, however, in Kronolith is completely  
>> broken. The TagActions Imple was removed, so the code responsible  
>> for attaching ajax actions to the "delete tag" icons and for  
>> attaching the the ajax action to to the "add" button for each  
>> calendar's tagger is now missing. Also, the fallback action for the  
>> buttons (to actually submit the page for non-javascript browsers)  
>> is missing as well.
>
> The Kronolith tagging was unintentionally lost.  Much like the Ansel  
> imple tag - these were the two imples that were so far off from what  
> imples were originally designed to do that it pretty much stopped my  
> refactoring in its place.  The eventual correct solution *at least  
> as done in Ansel) was to realize that none of these tagging actions  
> were appropriate for imples

I have to say that I don't see why tagging (as done in the traditional  
interface) is out of the scope for imples. We are attaching ajax  
actions to UI elements (deleting that tag, adding the tag). The  
complicating factor is of course that some of the UI elements (new  
tags) are added via ajax calls. Another complicating factor was the  
original requirement that the tagging form fail gracefully in the  
absence of javascript.

> so I just removed the imple entirely and moved the tag actions to  
> AJAX application method handlers.  The same needs to be done for  
> kronolith.

This is fine except that the tagging, even in Ansel, does not work.

> It would be nice if somehow tagging functionality shared between  
> ansel and kronolith could be abstracted into a base Imple, to create  
> a unified-API for tagging in future Horde applications

We might be able to share some js/imple code for the tagger, but we  
would still need to eventually have the application's tagger object do  
the actual tagging since we need to enfore some application specific  
rules/logic.

> But I don't know enough about the code to design/implement this kind  
> of solution myself.

I have no idea when I would have time to do this. Almost certainly not  
before the H5 release.

-- 
mike

The Horde Project (www.horde.org)
mrubinsk at horde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6096 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.horde.org/archives/dev/attachments/20120601/a404c8ea/attachment-0001.bin>