[dev] [commits] Horde branch develop updated. 6ada81f61cf5f82b679bade745e8a7a78d1fdf7b

[Michael M Slusarz]

Quoting Michael M Slusarz <slusarz at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>> commit 756d8f84ee6a3ded2587035f99e715242823f7c9
>> Author: Jan Schneider <jan at horde.org>
>> Date:   Tue Jun 26 21:20:56 2012 +0200
>>
>>    I guess this was intended?
>>
>> ingo/lib/Script/Imap/Live.php |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/756d8f84ee6a3ded2587035f99e715242823f7c9
>>
>> -----------------------------------------------------------------------
>>
>> commit 6ada81f61cf5f82b679bade745e8a7a78d1fdf7b
>> Author: Jan Schneider <jan at horde.org>
>> Date:   Wed Jun 27 16:35:58 2012 +0200
>>
>>    Hotfix: Always load HordeCore and Growler.
>>
>>    Since click handling has been delegated to HordeCore, it is required
>>    for almost any page. Individually including hordecore.js doesn't work
>>    anymore either, because HordeCore.conf is only set here. Finally the
>>    DOM loader always initializes Growler, whether it has been loaded or
>>    not.
>>
>> framework/Core/lib/Horde/PageOutput.php |    4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> http://git.horde.org/horde-git/-/commit/6ada81f61cf5f82b679bade745e8a7a78d1fdf7b
>
> Click handling has NOT been delegated to HordeCore.  It is only  
> handled by HordeCore if an application requests it.  So HordeCore is  
> not required for every page because of this.  Only IMP is currently  
> using this feature, and any IMP page that is broken just needs to  
> load this code.
>
> Where are we using HordeCore.conf but we are not loading hordecore.js?

Loading of hordecore.js (and potentially hordecore configuration) is  
the kind of thing that could be moved to the (newly developed) script  
packages.

In the future, I think it is appropriate to NEVER load any scripts by  
default - a page needs to explicitly identify its javascript  
dependencies.  Packages will make this easier to automate, since a  
page will be able to do something like this:

$page_output->addScriptPackage('Ajax');
$page_output->addScriptPackage('Growler');

and all required dependencies will be loaded (without duplication of code).

michael

___________________________________
Michael Slusarz [slusarz at horde.org]